I always vacuum before shocking my pool. Removing leaves, dirt, and debris first means the shock goes straight to sanitizing the water instead of getting “used up” on gunk. I usually skim, brush, vacuum, then add the shock, makes the water clear faster and prevents it from getting cloudy again. Doing it after shocking tends to stir everything up, which just slows the whole process.